Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bon transactions value #1048

Merged

Conversation

innocente205
Copy link
Contributor

When purchases were made from the store, the cost was being recorded as the 'value' from the bonexchange table instead of the cost

Name, Cost
'100 GB Upload', '107374182400.00'
'25 GB Upload', '26843545600.00'
'100 GB Upload', '107374182400.00'
'100 GB Upload', '107374182400.00'

@HDVinnie
Copy link
Collaborator

HDVinnie commented Jan 6, 2020

Good catch. Thanks for the PR. Guessing you caught this looking at the audit logs?

@HDVinnie HDVinnie merged commit 43ee29f into HDInnovations:master Jan 6, 2020
@innocente205
Copy link
Contributor Author

Thanks. Actually looking at the database.

@innocente205 innocente205 deleted the Update-BonTransactions-value branch January 6, 2020 16:58
@innocente205
Copy link
Contributor Author

Please note: this change breaks the reporting of 'upload added from BON store' in the users profile page.

HDVinnie added a commit that referenced this pull request Feb 12, 2020
- reverted until BON system is refactored.
howardlau1999 pushed a commit to sysu-ipv6/UNIT3D-Community-Edition that referenced this pull request Feb 12, 2020
- reverted until BON system is refactored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants